fix: 1.7.3 to 1.7.4 regression #193
Conversation
Remove the use of the deprecated Webpack MainTemplate. If `__nccwpck__` is not present, fall back to `__webpack_require__`. It fixes the regression from 1.7.3 to 1.7.4 vercel#188 and it also allows for compatibility with `rspack` https://github.com/web-infra-dev/rspack.
alfredomariamilano
changed the title
|
I'm sorry, I had not run the tests, as it was working as intended. I have a better understanding of how |
ran and updated all tests
|
Unfortunately, all tests had to be reran and rewritten and I kept |
|
Looks like the module ids are different on linux |
|
🎉 This issue has been resolved in version 1.7.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…rcel#195) While exploring the idea of dropping ncc and using webpack to build the loader directly in [this branch](https://github.com/yjoer/webpack-asset-relocator-loader/tree/patch-2), I noticed that 31 outputs differ from their corresponding coverage outputs. These differences are consistent across the changes made here, so I believe we can update the coverage outputs to reflect this variation. - Fixes: vercel#188 - Closes vercel#193 --------- Co-authored-by: Alfredo Maria Milano <[email protected]> Co-authored-by: Steven <[email protected]>
2 participants
Remove the use of the deprecated Webpack MainTemplate. If
__nccwpck__is not present, fall back to__webpack_require__. It fixes the regression from 1.7.3 to 1.7.4 and it also allows for compatibility with rspack.